Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gapless aware seek handling #1346

Merged
merged 8 commits into from Dec 5, 2015
Merged

Conversation

adamcik
Copy link
Member

@adamcik adamcik commented Dec 4, 2015

Fixes: #312, #1304 (partially), #1305

Changelog to follow once I've reviewed the diff again.

@adamcik adamcik added the A-core Area: Core layer label Dec 4, 2015
@adamcik adamcik added this to the v1.2 - Gapless milestone Dec 4, 2015
Technically the seek still needs to be postponed for this to work right, but
it's a step closer.
Makes sure to only fire when the position changed to our intended seek target.
Otherwise we would also be triggering this when playback starts.
This covers over that audio will fail query position while a seek is in
progress. It also means that instead of returning zero we at least return
something which is much closer to the time that we will soon end up playing
from.
@adamcik adamcik mentioned this pull request Dec 4, 2015
@@ -16,6 +16,11 @@ Core API
- Start ``tlid`` counting at 1 instead of 0 to keep in sync with MPD's
``songid``.

- `get_time_position` now returns the seek target while a seek is in progress.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either you need double backtick quotes or use :meth:~mopidy.core.PlaybackController.get_time_position.

@jodal
Copy link
Member

jodal commented Dec 4, 2015

Reviewed commit by commit. LGTM.

@jodal jodal self-assigned this Dec 4, 2015
@adamcik
Copy link
Member Author

adamcik commented Dec 5, 2015

Done.

- Seek events are now triggered when the seek completes. Previously the event
was emitted when the seek was requested, not when it completed. Further
changes have been made to make seek work correctly for gapless related corner
cases. (Fixes: :issue:`1305` PR: :pr:`1346`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Same comments as above" means that :pr: must be replaced with :issue: here as well. ;-)

@adamcik
Copy link
Member Author

adamcik commented Dec 5, 2015

Done

jodal added a commit that referenced this pull request Dec 5, 2015
@jodal jodal merged commit 23cdeb2 into mopidy:develop Dec 5, 2015
@adamcik adamcik deleted the feature/eot-seek-handling branch December 5, 2015 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants