MPD idle cleanup

[adamcik]

This combined with #1346 provides a much nicer experience when seeking as clients are far less likely to end up out of sync.

[jodal]

"unreported/undiagnosed"

[jodal]

LGTM, with comments :-)

[adamcik]

I'm considering the following change to this handling as we don't really ever care about the kwargs we just need to know what event fired and map it. Thoughts?

_CORE_EVENTS_TO_IDLE_SUBSYSTEMS = {                                             
    'track_playback_paused': None,                                              
    'track_playback_resumed': None,                                             
    'track_playback_started': None,                                             
    'track_playback_ended': None,                                               
    'playback_state_changed': 'player',                                         
    'tracklist_changed': 'playlist',                                            
    'playlists_loaded': 'stored_playlist',                                      
    'playlist_changed': 'stored_playlist',                                      
    'playlist_deleted': 'stored_playlist',                                      
    'options_changed': 'options',                                               
    'volume_changed': 'mixer',                                                  
    'mute_changed': 'output',                                                   
    'seeked': 'player',                                                         
    'stream_title_changed': 'playlist',                                         
} 

....

class MpdFrontend(...):
    ....

   def on_event(self, event, **kwargs):                                          
        if event not in _CORE_EVENTS_TO_IDLE_SUBSYSTEMS:                          
            logger.warning(                                                       
                'Got unexpected event: %s(%s)', event, ', '.join(kwargs))         
        else:                                                                     
            self.send_idle(_CORE_EVENTS_TO_IDLE_SUBSYSTEMS[event]) 

[adamcik]

This probably doesn't make sense, reasoning being that we need to add playlists_loaded, playlist_changed, playlist_deleted handling which will update the URI mapper based on changes.

[jodal]

I think this looks good, and I like that fact that it will complain when we add a new core event and forgets to update MPD.

As for URI mapper maintenance, I'm OK with a if/elif/elif block after the above code.

[adamcik]

Comments have been addressed, just my last suggestion / question left now.

[adamcik]

Oh, and the fix for playlist_deleted could probably be backported to a bugfix release if we want to.

[jodal]

Feel free to cherry-pick the playlists_deleted commit to the release-1.1 branch. I'd like to make an 1.1.2 release soon.

[adamcik]

Done