New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add PlaylistsController.get_uri_schemes(). #1362

Merged
merged 1 commit into from Dec 28, 2015

Conversation

3 participants
@tkem
Member

tkem commented Dec 13, 2015

Adds a new method PlaylistsController.get_uri_schemes() which mirrors Core.get_uri_schemes(), but only returns schemes for backends with a playlists provider.

This can be used by clients which want to pass the optional uri_scheme parameter to PlaylistsController.create(). Without this, clients will usually

  • do not use the uri_scheme parameter at all, so playlists get created by the first backend that provides playlists (not always what's desired, and there need not be a playlist-aware backend installed)
  • set uri_scheme to a hard-coded value, for example m3u, which may not even be available
  • let the user choose from the URI schemes provided by Core.get_uri_schemes(), which reports backends that don't provide playlist support, too

See also tkem/mopidy-mobile#146 for the original motivation for this.

Would be nice if this could be included in v1.2.

@jodal

This comment has been minimized.

Member

jodal commented Dec 28, 2015

As none of our plans for changing from URI scheme matching to URI prefix matching has made it into the source yet, I'm positive to merging this addition now, even though it will be replaced down the road.

👍

@adamcik Any comments?

@jodal jodal added this to the v1.2 - Gapless and GStreamer 1.x milestone Dec 28, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Dec 28, 2015

Should be fine, and we can always make backwards compatible with future extension that might only set prefixes.

@jodal jodal self-assigned this Dec 28, 2015

@jodal jodal added the A-core label Dec 28, 2015

jodal added a commit that referenced this pull request Dec 28, 2015

Merge pull request #1362 from tkem/feature/playlists-schemes
core: Add PlaylistsController.get_uri_schemes().

@jodal jodal merged commit 2a04088 into mopidy:develop Dec 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal

This comment has been minimized.

Member

jodal commented Dec 28, 2015

Thanks :-)

@jodal

This comment has been minimized.

Member

jodal commented Dec 28, 2015

I love it when I can just push "merge" and not do anything myself, like updating the changelog!

@tkem tkem deleted the tkem:feature/playlists-schemes branch Jan 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment