New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing or empty 'port' configuration parameter. #1371

Merged
merged 1 commit into from Dec 29, 2015

Conversation

2 participants
@jcass77
Member

jcass77 commented Dec 26, 2015

Logic and test case to handle situation where the port parameter is either missing from the configuration file entirely, or set to an empty string.

@jodal jodal added this to the v1.2 - Gapless and GStreamer 1.x milestone Dec 29, 2015

@jodal jodal self-assigned this Dec 29, 2015

jodal added a commit that referenced this pull request Dec 29, 2015

Merge pull request #1371 from jcass77/enhance/format_proxy
Handle missing or empty 'port' configuration parameter.

@jodal jodal merged commit 811131f into mopidy:develop Dec 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal

This comment has been minimized.

Member

jodal commented Dec 29, 2015

Thanks!

@jcass77 jcass77 deleted the jcass77:enhance/format_proxy branch Jan 2, 2016

@jodal

This comment has been minimized.

Member

jodal commented Jan 5, 2016

I cherry-picked this fix to release-1.1 in commits c2c2aa0 and 38307a5.

@jodal jodal modified the milestones: v1.1.2 - Bugfixes, v1.2 - Gapless and GStreamer 1.x Jan 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment