New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip over unplayable tracks when paused #1379

Merged
merged 4 commits into from Jan 3, 2016

Conversation

2 participants
@jcass77
Member

jcass77 commented Dec 29, 2015

Proposed fixes for #1378.

This PR is based on #1356 as the changes overlap somewhat, so should probably be merged in that sequence.

The quick fix in PlaybackController._change_track is becoming little messy as it now includes hacks for three issues :( But a lot of this has changed in gapless so should be ok if there are no further changes?

@jodal

This comment has been minimized.

Member

jodal commented Dec 29, 2015

PR #1356 has been merged into release-1.1. Can you rebase and force-push this PR?

@jodal jodal added this to the v1.1.2 - Bugfixes milestone Dec 29, 2015

@jodal jodal added the A-core label Dec 29, 2015

@jodal jodal self-assigned this Dec 29, 2015

@jcass77

This comment has been minimized.

Member

jcass77 commented Dec 30, 2015

Yes certainly. I'm away from keyboard for a few days but should be able to pick this up again on Saturday.

@jodal

This comment has been minimized.

Member

jodal commented Jan 1, 2016

Great! Just in time for a Mopidy 1.1.2 release this weekend :-)

@jcass77 jcass77 force-pushed the jcass77:fix/1378 branch from 15a3d70 to f2194e9 Jan 2, 2016

@jcass77

This comment has been minimized.

Member

jcass77 commented Jan 2, 2016

I've performed the rebase and force-pushed to release-1.1.

Thank you!

jodal added a commit that referenced this pull request Jan 3, 2016

Merge pull request #1379 from jcass77/fix/1378
Skip over unplayable tracks when paused

@jodal jodal merged commit d4d5fb4 into mopidy:release-1.1 Jan 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal

This comment has been minimized.

Member

jodal commented Jan 3, 2016

Thanks :-)

@jcass77 jcass77 deleted the jcass77:fix/1378 branch Jan 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment