core: Make lookup() ignore tracks without URI #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -236,7 +236,7 @@ def lookup(self, uri=None, uris=None): | |||
| result = future.get() | |||
| if result is not None: | |||
| validation.check_instances(result, models.Track) | |||
| results[u] = result | |||
| results[u] = [r for r in result if r.uri] | |||
There was a problem hiding this comment.
Maybe add a note or TODO to revisit this if we make the URI mandatory. So maybe just # Silently drop tracks without URIs as this crashes some clients. And on a side note should we log what backend sent the bad data?
There was a problem hiding this comment.
I'm adding a note about making Track.uri mandatory instead. When we do that, backend's will fail to create the broken objects and will thus quickly get feedback and get fixed. Don't want to add too much logic in an inner loop.
|
Other than that optional comment this looks good to merge. |
jodal
added a commit
that referenced
this pull request
Jan 3, 2016
core: Make lookup() ignore tracks without URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1340