Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track_playback_ended event in consume mode #1403

Merged
merged 3 commits into from Jan 20, 2016

Conversation

@jcass77
Copy link
Member

commented Jan 20, 2016

Proposed solution for #1402.

@@ -491,6 +491,35 @@ def test_next_emits_events(self, listener_mock):
],
listener_mock.send.mock_calls)

def test_next_emits_events_when_consume_mode_is_enabled(self,
listener_mock):

This comment has been minimized.

Copy link
@jodal

jodal Jan 20, 2016

Member

I'd break the line after ( here and indent self one level more than the following tl_tracks ... line. This is however still flake8 compliant, so I won't stand my ground.

@jodal jodal added this to the v1.2 - Gapless and GStreamer 1.x milestone Jan 20, 2016

@jodal jodal self-assigned this Jan 20, 2016

jodal added a commit that referenced this pull request Jan 20, 2016

Merge pull request #1403 from jcass77/fix/1402_track_playback_ended
Fix track_playback_ended event in consume mode

@jodal jodal merged commit 88e9a12 into mopidy:develop Jan 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal

This comment has been minimized.

Copy link
Member

commented Jan 20, 2016

Nice catch and simple solution :-)

jcass77 added a commit that referenced this pull request Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.