Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track_playback_ended event in consume mode #1403

Merged
merged 3 commits into from Jan 20, 2016

Conversation

jcass77
Copy link
Member

@jcass77 jcass77 commented Jan 20, 2016

Proposed solution for #1402.

@@ -491,6 +491,35 @@ def test_next_emits_events(self, listener_mock):
],
listener_mock.send.mock_calls)

def test_next_emits_events_when_consume_mode_is_enabled(self,
listener_mock):
Copy link
Member

@jodal jodal Jan 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd break the line after ( here and indent self one level more than the following tl_tracks ... line. This is however still flake8 compliant, so I won't stand my ground.

@jodal jodal added this to the v1.2 - Gapless and GStreamer 1.x milestone Jan 20, 2016
@jodal jodal self-assigned this Jan 20, 2016
jodal added a commit that referenced this issue Jan 20, 2016
Fix track_playback_ended event in consume mode
@jodal jodal merged commit 88e9a12 into mopidy:develop Jan 20, 2016
1 check passed
@jodal
Copy link
Member

@jodal jodal commented Jan 20, 2016

Nice catch and simple solution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants