New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone tags between about-to-finish and stream-start #1439

Merged
merged 3 commits into from Feb 14, 2016

Conversation

2 participants
@adamcik
Member

adamcik commented Feb 13, 2016

Don't think this needs a changlog entry. The bad behavior this fixes was never released.

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 13, 2016

But the other change I snuck in regarding how often we trigger metadata changed might need one?

@jodal jodal self-assigned this Feb 13, 2016

@jodal

This comment has been minimized.

Member

jodal commented Feb 13, 2016

LGTM. A changelog entry for the reduced amount tags in the tag_changed event would be nice, even though it should just be positive news for any users of it.

adamcik added some commits Feb 13, 2016

audio: Only emit tags changed when tags changed.
Previously we alerted AudioListeners about all new tags, now we filter it down
to just the changed ones. Only real reason for this is that the changed
messages spam the log output making debugging harder.
audio: Postpone tags until after stream-start
When a new URI gets set we create a pending tags dictionary. This gets all the
tags until stream-start, at which point they are all emitted at once. During
track playback tags works as before.

This ensure we don't prematurely tell clients about metadata changes.

@adamcik adamcik force-pushed the adamcik:fix/1304-postpone-tags branch from 02aeda2 to d20621c Feb 14, 2016

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 14, 2016

Added, and rebased due to the changelog conflict.

jodal added a commit that referenced this pull request Feb 14, 2016

Merge pull request #1439 from adamcik/fix/1304-postpone-tags
Postpone tags between about-to-finish and stream-start

@jodal jodal merged commit 7a8d166 into mopidy:develop Feb 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jodal jodal referenced this pull request Feb 14, 2016

Closed

gapless: Event handling #1304

4 of 4 tasks complete

@adamcik adamcik deleted the adamcik:fix/1304-postpone-tags branch Feb 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment