Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the stream backend playback/library handle URIs the same way #1447

Merged
merged 7 commits into from
Feb 15, 2016

Conversation

adamcik
Copy link
Member

@adamcik adamcik commented Feb 14, 2016

Probably replaces #1446. Main thing missing for 2.0 is a changelog, but it's time for bed now...

@adamcik adamcik added the C-bug Category: This is a bug label Feb 14, 2016
@jodal jodal self-assigned this Feb 15, 2016
library = actor.StreamLibraryProvider(backend, [])
def test_lookup_ignores_unknown_scheme(audio, config):
backend = actor.StreamBackend(audio=audio, config=config)
backend.library.lookup('http://example.com') == []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing assert

@jodal
Copy link
Member

jodal commented Feb 15, 2016

👍 with comments and a changelog entry

@adamcik
Copy link
Member Author

adamcik commented Feb 15, 2016

Should get to it this evening.

jodal added a commit that referenced this pull request Feb 15, 2016
Make sure the stream backend playback/library handle URIs the same way
@jodal jodal merged commit 9a6636a into mopidy:develop Feb 15, 2016
@adamcik adamcik deleted the fix/1445-unify-stream-uri-handling branch February 15, 2016 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants