Find images in audio files #1472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle Gst.Sample as image in audio file tags (scaned with Gst1.0).
Always unmap the mapped memory, even in case of exception.
|
The |
| @@ -53,6 +53,14 @@ def convert_taglist(taglist): | |||
| result[tag].append(value.decode('utf-8', 'replace')) | |||
| elif isinstance(value, (compat.text_type, bool, numbers.Number)): | |||
| result[tag].append(value) | |||
| elif isinstance(value, Gst.Sample): | |||
| buf = value.get_buffer() | |||
There was a problem hiding this comment.
https://lazka.github.io/pgi-docs/#Gst-1.0/structs/Sample.html#Gst.Sample.get_buffer says get_buffer() can return None, code should probably check for that.
|
Addressing the one comment myself and merging this into the release-2.0 branch. |
|
And I have a 14.04 machine myself, so will take a quick look at that. |
|
Pushed your cherry-picked changes pluss a few extra changes to the release-2.0 branch. |
|
793e425 works around the warnings for old GStreamer python bindings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Gst.Sample as image in audio file tags (scanned with Gst1.0).
Fixes #1469
This patch works well on my RPi with raspbian.
On my Ubuntu 14.04 the
Gst.Buffer.map()fail with a c error.Any Idea? Corrupted Ubuntu?