New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find images in audio files #1472

Closed
wants to merge 2 commits into
base: develop
from

Conversation

3 participants
@dublok
Contributor

dublok commented Feb 27, 2016

Handle Gst.Sample as image in audio file tags (scanned with Gst1.0).

Fixes #1469

This patch works well on my RPi with raspbian.

On my Ubuntu 14.04 the Gst.Buffer.map() fail with a c error.

** (python:10510): CRITICAL **: Unable to determine array length for 0x7fa0901c0e90

Any Idea? Corrupted Ubuntu?

dublok added some commits Feb 27, 2016

Find images in audio files
Handle Gst.Sample as image in audio file tags (scaned with Gst1.0).
Always unmap mapped buffer.
Always unmap the mapped memory, even in case of exception.

@jodal jodal added this to the v2.0.1 - Bug fixes milestone Mar 1, 2016

@dublok

This comment has been minimized.

Contributor

dublok commented Mar 2, 2016

The Gst.Buffer.map() code is working on Ubuntu 15.10.
I assume that the patch is OK and Ubuntu 14.04 has an issue.

@@ -53,6 +53,14 @@ def convert_taglist(taglist):
result[tag].append(value.decode('utf-8', 'replace'))
elif isinstance(value, (compat.text_type, bool, numbers.Number)):
result[tag].append(value)
elif isinstance(value, Gst.Sample):
buf = value.get_buffer()

This comment has been minimized.

@adamcik

adamcik Mar 25, 2016

Member

https://lazka.github.io/pgi-docs/#Gst-1.0/structs/Sample.html#Gst.Sample.get_buffer says get_buffer() can return None, code should probably check for that.

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 25, 2016

Addressing the one comment myself and merging this into the release-2.0 branch.

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 25, 2016

And I have a 14.04 machine myself, so will take a quick look at that.

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 25, 2016

Pushed your cherry-picked changes pluss a few extra changes to the release-2.0 branch.

@adamcik adamcik closed this Mar 25, 2016

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 25, 2016

793e425 works around the warnings for old GStreamer python bindings.

jodal added a commit that referenced this pull request Mar 26, 2016

tmyersjstar added a commit to tmyersjstar/mopidy that referenced this pull request Apr 5, 2016

@dublok dublok deleted the dublok:fix/1469-image-tag-extraction branch Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment