New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: fix protocol for replay_gain_status #1520

Merged
merged 1 commit into from May 31, 2016

Conversation

3 participants
@bchretien
Contributor

bchretien commented May 31, 2016

I found an error in the implementation of the MPD protocol:

  • with mpd 0.19.5:
$ telnet 127.0.0.1 6600
...
OK MPD 0.19.0
replay_gain_status
replay_gain_mode: off
OK
  • with mopidy df0d534 (current develop branch):
$ telnet 127.0.0.1 6600
...
OK MPD 0.19.0
replay_gain_status
off
OK

This led to the following issue. This PR is a simple attempt at solving the issue (without implementing actual replay gain support).

@bchretien bchretien force-pushed the bchretien:topic/fix-mpd-protocol branch from 14139a9 to 1bd9228 May 31, 2016

@kingosticks

This comment has been minimized.

Member

kingosticks commented May 31, 2016

If this had a brief changelog entry it would be perfect, would you mind adding something?

@adamcik

This comment has been minimized.

Member

adamcik commented May 31, 2016

Did a quick check of this feature on the MPD side, and is seems it has had the replay_gain_mode: prefix since the feature was added in 0.16 - so sadly an oversight on our part.

@adamcik adamcik added the C-bug label May 31, 2016

@adamcik adamcik added this to the v2.1 - The rest of v2.0 milestone May 31, 2016

@bchretien bchretien force-pushed the bchretien:topic/fix-mpd-protocol branch from 1bd9228 to 37cd296 May 31, 2016

@bchretien

This comment has been minimized.

Contributor

bchretien commented May 31, 2016

Thanks for the quick feedback! Changelog updated.

@kingosticks

This comment has been minimized.

Member

kingosticks commented May 31, 2016

@adamcik Is this not also for v2.0.1?

@kingosticks kingosticks merged commit 2fe9fbb into mopidy:develop May 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kingosticks

This comment has been minimized.

Member

kingosticks commented May 31, 2016

Thanks @bchretien

@bchretien bchretien deleted the bchretien:topic/fix-mpd-protocol branch Jun 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment