Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/1521 download timeout sec #1522

Merged
merged 2 commits into from Jun 13, 2016

Conversation

@SeppSTA
Copy link
Contributor

@SeppSTA SeppSTA commented Jun 1, 2016

default timeout is converted from ms to seconds for http download and warning has correct number of arguments. Fix avoids blocking of mopidy while it is busy downloading whole stream for a unfortunately long period.

@camilonova
Copy link
Contributor

@camilonova camilonova commented Jun 11, 2016

I can confirm this is working. Please merge it.

Loading

@adamcik adamcik merged commit d02f841 into mopidy:develop Jun 13, 2016
1 check passed
Loading
@adamcik
Copy link
Member

@adamcik adamcik commented Jun 13, 2016

Missing a changelog entry, but looks good otherwise. Should be backported to 2.0.x for the next patch release.

Loading

@adamcik adamcik added the C-bug label Jun 13, 2016
@adamcik adamcik added this to the v2.0.1 - Bug fixes milestone Jun 13, 2016
@adamcik adamcik self-assigned this Jun 13, 2016
@camilonova
Copy link
Contributor

@camilonova camilonova commented Jun 13, 2016

Thank you

Loading

kingosticks added a commit to kingosticks/mopidy-tunein that referenced this issue Jun 14, 2016
adamcik added a commit that referenced this issue Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants