New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1133 Add nextsong and nextsongid to mpd status command #1523

Merged
merged 7 commits into from Jun 26, 2016

Conversation

2 participants
@ismailof
Contributor

ismailof commented Jun 6, 2016

The PR adds nextsong and nextsongid to mpd status command.
The ID of the next track to be played is provided by tracklist.get_next_tlid()

It also fixes #1516 (duplicated)

@adamcik adamcik added the A-mpd label Jun 13, 2016

@adamcik adamcik added this to the v2.1 - The rest of v2.0 milestone Jun 13, 2016

@adamcik

This comment has been minimized.

Member

adamcik commented Jun 13, 2016

@@ -185,6 +186,9 @@ def status(context):
'playback.state': context.core.playback.get_state(),
'playback.current_tl_track': tl_track,
'tracklist.index': context.core.tracklist.index(tl_track.get()),
'tracklist.next_tlid': next_tlid,
'tracklist.next_index': context.core.tracklist.index(
tlid=next_tlid.get()),

This comment has been minimized.

@adamcik

adamcik Jun 13, 2016

Member

Ideally we shouldn't have this .get() inside here. But given the APIs that are currently available this is the correct way to do it as far as I can see.

@adamcik

This comment has been minimized.

Member

adamcik commented Jun 13, 2016

A quick changelog entry for this would be awesome, rest looks good to me.

@ismailof

This comment has been minimized.

Contributor

ismailof commented Jun 18, 2016

I'm not at home for a while. When I come back next week I'll add the note in the changelog.

@adamcik

This comment has been minimized.

Member

adamcik commented Jun 26, 2016

Perfect, thanks for the contribution and following up on this.

I looked into the now failing travis test, looks unrelated to your change so just double checking that before merging :-)

@adamcik

This comment has been minimized.

Member

adamcik commented Jun 26, 2016

I rebuilt https://travis-ci.org/mopidy/mopidy/builds/137349654 which was known good and it now fails... So going ahead and merging your change and we'll have to unbreak the build for everyone using a newer flake8.

@adamcik adamcik merged commit 068800c into mopidy:develop Jun 26, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@ismailof ismailof deleted the ismailof:fix/1133-mpd-nextsongid branch Jun 26, 2016

edran added a commit to edran/mopidy that referenced this pull request Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment