New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the date in a tag is invalid, skip it #1525

Merged
merged 2 commits into from Jul 25, 2016

Conversation

2 participants
@palfrey
Contributor

palfrey commented Jun 10, 2016

Fixes #1506

result[tag].append(date.isoformat().decode('utf-8'))
except ValueError:
logger.log(
logging.DEBUG,

This comment has been minimized.

@adamcik

adamcik Jun 13, 2016

Member

Should just be logger.debug(...) no need to use log().

This comment has been minimized.

@palfrey

palfrey Jun 13, 2016

Contributor

Fixed

@adamcik

This comment has been minimized.

Member

adamcik commented Jun 13, 2016

Note to self, also credit @mlang for #1517 even though this change will go in instead.

@adamcik adamcik merged commit 57b8b84 into mopidy:develop Jul 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

adamcik added a commit that referenced this pull request Jul 25, 2016

Merge pull request #1525 from palfrey/dodgy-date-tags
If the date in a tag is invalid, skip it
@adamcik

This comment has been minimized.

Member

adamcik commented Jul 25, 2016

Thanks for the contribution, this has been backported to 2.0.x so we can hopefully do a point release with this really soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment