Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: Postpone set_metadata until track is playing #1538

Closed

Conversation

@adamcik
Copy link
Member

@adamcik adamcik commented Jul 28, 2016

No description provided.

@@ -800,12 +805,11 @@ def set_value(tag, value):
if track.album and track.album.name:
set_value(Gst.TAG_ALBUM, track.album.name)

gst_logger.debug(
'Sending TAG event for track %r: %r',
track.uri, taglist.to_string())

This comment has been minimized.

@jodal

jodal Aug 7, 2016
Member

Can we keep this debug log stmt?

event = Gst.Event.new_tag(taglist)
# TODO: check if we get this back on our own bus?
self._playbin.send_event(event)
if not self._pending_uri:

This comment has been minimized.

@jodal

jodal Aug 7, 2016
Member

I think this reads a bit better if we flip the order of the branches.

@jodal jodal self-assigned this Aug 7, 2016
@jodal
Copy link
Member

@jodal jodal commented Aug 7, 2016

I've fixed my own comments and merged this into my local release-2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants