New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1508: identifier field encoding error #1546

Merged
merged 2 commits into from Aug 11, 2016

Conversation

2 participants
@jodal
Member

jodal commented Aug 7, 2016

No description provided.

@jodal jodal added this to the v2.0.1 - Bug fixes milestone Aug 7, 2016

@adamcik

This comment has been minimized.

Member

adamcik commented Aug 10, 2016

Update :class:Fieldfor storing ASCII values such as GUIDs or other identifiers. to not specify ASCII. Also does this have implications for the URI field?

@jodal jodal force-pushed the jodal:fix/1508-identifier-field-encoding-error branch from 66b23d2 to 3346778 Aug 11, 2016

@jodal

This comment has been minimized.

Member

jodal commented Aug 11, 2016

Updated docstring.

The implication for the URI field should only be that it now won't crash if you put Unicode with non-ASCII into it. Ideally, we've already urlencoded it to ASCII before inserting it into the model.

@jodal jodal merged commit 41559cf into mopidy:release-2.0 Aug 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jodal jodal deleted the jodal:fix/1508-identifier-field-encoding-error branch Aug 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment