Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: Remove http/static_dir support #1706

Merged
merged 1 commit into from Oct 3, 2018

Conversation

@jodal
Copy link
Member

jodal commented Sep 30, 2018

Fixes #1463

@jodal jodal added this to the v3.0 milestone Sep 30, 2018
@jodal jodal self-assigned this Sep 30, 2018
@jodal jodal requested review from adamcik and kingosticks Sep 30, 2018
@jodal jodal force-pushed the jodal:feature/1463-remove-static-dir-support branch from 95c4e1c to b382c14 Sep 30, 2018
Copy link
Member

kingosticks left a comment

Some docs nitpicking from me while we are here.


3. Change the :confval:`http/static_dir` config value to point to your new
directory.
3. Use the :ref:`http-server-api` to make the extension host your static files,

This comment has been minimized.

Copy link
@kingosticks

kingosticks Oct 2, 2018

Member

Use the :ref:http-server-api to make the extension host your static files, like HTML, CSS, and JavaScript.

Use the :ref:http-server-api to serve a directory containing your extension's static HTML, CSS, and JavaScript files.


4. Start/restart Mopidy.
4. Create a file in your extension's static files directory named

This comment has been minimized.

Copy link
@kingosticks

kingosticks Oct 2, 2018

Member

Create a file in your extension's static files directory named index.html containing e.g. "Hello, world!".

Create a file in your extension's static files directory named index.html containing the text "Hello, world!".

Fixes #1463
@jodal jodal force-pushed the jodal:feature/1463-remove-static-dir-support branch from b382c14 to 9cc10db Oct 3, 2018
@jodal jodal merged commit 7c1f442 into mopidy:develop Oct 3, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal jodal deleted the jodal:feature/1463-remove-static-dir-support branch Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.