Skip to content

/mopidy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: use current Tornado IOLoop when stopping. (Fixes #1715). #1716

Merged
merged 1 commit into from Oct 22, 2018
+11 −3

Conversation

@kingosticks
Copy link
Member

commented Oct 20, 2018

From Tornado v5.0:

IOLoop.instance is now a deprecated alias for IOLoop.current. Applications that need the cross-thread communication behavior facilitated by IOLoop.instance should use their own global variable instead.

We were using IOLoop.instance to stop the HTTP server thread from a different thread.

@kingosticks kingosticks force-pushed the kingosticks:fix/hang-on-stopping-http branch from a22ba85 to d6a5f82 Oct 20, 2018

@kingosticks kingosticks requested a review from jodal Oct 20, 2018

@jodal

jodal approved these changes Oct 21, 2018
View changes

Copy link
Member

left a comment

I assume this works for Tornado 4.4 and upwards?
@kingosticks

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Oct 21, 2018

Yep I did a few tests on both tornado 5 and 4.4, seems fine.
@jodal

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 21, 2018

Maybe target this for the release-2.2 branch? And add a changelog entry.
@kingosticks
http: use current Tornado IOLoop when stopping. (Fixes #1715). 
This is in response to the breaking change in Tornado v5.0 where
IOLoop.instance is now a deprecated alias for IOLoop.current.
More info at https://www.tornadoweb.org/en/stable/releases/v5.0.0.html
Loading status checks…
1d30e73

@kingosticks kingosticks force-pushed the kingosticks:fix/hang-on-stopping-http branch from d6a5f82 to 1d30e73 Oct 22, 2018

@kingosticks kingosticks changed the base branch from develop to release-2.2 Oct 22, 2018

@jodal jodal assigned kingosticks Oct 22, 2018

@jodal jodal added this to the v2.2.2 milestone Oct 22, 2018

@jodal jodal added the A-http label Oct 22, 2018

@jodal jodal merged commit 10c571b into mopidy:release-2.2 Oct 22, 2018
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jodal jodal referenced this pull request Oct 22, 2018

Closed

Mopidy doesn't exit with Tornado v5.0+ #1715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodal jodal

Assignees

@kingosticks kingosticks

Labels
A-http
Milestone
  v2.2.2
2 participants
@kingosticks @jodal
You can’t perform that action at this time.