Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: removed unused fakesink. (Fixes #1528) #1735

Merged

Conversation

@kingosticks
Copy link
Member

commented Jan 16, 2019

The 'always connected fakesink' is causing problems when switching
between tracks with different sample rates and with some custom
output pipelines. Since it's only there to support dynamic outputs,
which we don't yet support, we might as well remove it for now.

@jodal jodal added this to the v2.2.3 milestone Jan 16, 2019

@jodal

jodal approved these changes Jan 29, 2019

Copy link
Member

left a comment

Rebase on top of release-2.2 and update the v2.2.3 changelog.

@jodal jodal added the A-audio label Jan 29, 2019

@kingosticks kingosticks changed the base branch from develop to release-2.2 Jan 29, 2019

@kingosticks kingosticks changed the base branch from release-2.2 to develop Jan 29, 2019

audio: removed unused fakesink. (Fixes #1528)
The 'always connected fakesink' is causing problems when switching
between tracks with different sample rates and with some custom
output pipelines. Since it's only there to support dynamic outputs,
which we don't yet support, we might as well remove it for now.

@kingosticks kingosticks force-pushed the kingosticks:fix/change-track-sample-rates branch from 4cf4458 to 5e8fd9a Jan 29, 2019

@kingosticks kingosticks changed the base branch from develop to release-2.2 Jan 29, 2019

@kingosticks kingosticks merged commit 6f615d3 into mopidy:release-2.2 Jan 30, 2019

@kingosticks kingosticks deleted the kingosticks:fix/change-track-sample-rates branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.