Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local, file: exclude .pdf and .zip in default config #1737

Merged
merged 1 commit into from Jan 29, 2019

Conversation

danstowell
Copy link
Contributor

@danstowell danstowell commented Jan 27, 2019

Hi - my local music collection is littered with PDF and Zip and it seems to me there's no reason not to exclude them, right? JPEGs are excluded by default (e.g. cover art) and actually that's the same reason why I have PDFs - "liner notes" etc. I hope this proposed pull is appropriate. Thanks for your work.

@kingosticks
Copy link
Member

@kingosticks kingosticks commented Jan 29, 2019

I'm just trying to remember why File's exclusion list doesn't match Local's, particularly since File's has a more noticeable performance improvement.

@kingosticks kingosticks merged commit 8f8d00b into mopidy:develop Jan 29, 2019
1 check passed
@jodal
Copy link
Member

@jodal jodal commented Jan 29, 2019

My only nitpick here is that the new extensions should be ordered alphabetically, like the existing ones.

I don't remember why local and file has different exclusion lists.

@kingosticks
Copy link
Member

@kingosticks kingosticks commented Jan 29, 2019

I'll re-order them when I sync the two lists up. And I'll do that when I understand what's going on with Travis.

@jodal jodal added this to the v2.2.3 milestone Jan 29, 2019
@jodal
Copy link
Member

@jodal jodal commented Jan 29, 2019

@kingosticks Also, consider cherry-picking this to the release-2.2 branch and add it to the v2.2.3 changelog.

@jodal jodal added A-local C-enhancement A-file labels Jan 29, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Jan 31, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-file C-enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants