Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesDisable buffering handling during track change. (Fixes #1722) #1740
Conversation
kingosticks
referenced this pull request
Jan 31, 2019
Closed
audio: Do not handle buffering message. (Fixes #1722) #1734
jodal
added this to the v2.2.3 milestone
Jan 31, 2019
jodal
added
the
A-audio
label
Jan 31, 2019
jodal
approved these changes
Jan 31, 2019
mopidy/audio/actor.py
Outdated
| @@ -740,6 +743,9 @@ def _set_state(self, state): | |||
| :type state: :class:`Gst.State` | |||
| :rtype: :class:`True` if successfull, else :class:`False` | |||
| """ | |||
| if (state < Gst.State.PAUSED): | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kingosticks
Jan 31, 2019
Author
Member
You'd have thought I would have noticed when I already went and removed the semicolons at the end of lines.
This comment has been minimized.
This comment has been minimized.
|
Rebase on top of release-2.2? |
kingosticks
added some commits
Jan 30, 2019
kingosticks
force-pushed the
kingosticks:fix/change-track-buffering-alt
branch
from
079cf7d
to
d6da4b5
Jan 31, 2019
kingosticks
changed the base branch from
develop
to
release-2.2
Jan 31, 2019
kingosticks
merged commit e5c03fb
into
mopidy:release-2.2
Jan 31, 2019
kingosticks
deleted the
kingosticks:fix/change-track-buffering-alt
branch
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kingosticks commentedJan 31, 2019
Successor to #1734 which retains our GST
BUFFERINGmessage handling but prevents it from erroneously setting the pipeline statePLAYING/PAUSEDwhen we want to stay inREADY(during track changes).