Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable buffering handling during track change. (Fixes #1722) #1740

Merged

Conversation

kingosticks
Copy link
Member

@kingosticks kingosticks commented Jan 31, 2019

Successor to #1734 which retains our GST BUFFERING message handling but prevents it from erroneously setting the pipeline state PLAYING/PAUSED when we want to stay in READY (during track changes).

@jodal jodal added this to the v2.2.3 milestone Jan 31, 2019
@jodal jodal added the A-audio label Jan 31, 2019
jodal
jodal approved these changes Jan 31, 2019
@@ -740,6 +743,9 @@ def _set_state(self, state):
:type state: :class:`Gst.State`
:rtype: :class:`True` if successfull, else :class:`False`
"""
if (state < Gst.State.PAUSED):
Copy link
Member

@jodal jodal Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parenthesis are redundant.

Copy link
Member Author

@kingosticks kingosticks Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have thought I would have noticed when I already went and removed the semicolons at the end of lines.

@jodal
Copy link
Member

@jodal jodal commented Jan 31, 2019

Rebase on top of release-2.2?

@kingosticks kingosticks force-pushed the fix/change-track-buffering-alt branch from 079cf7d to d6da4b5 Compare Jan 31, 2019
@kingosticks kingosticks changed the base branch from develop to release-2.2 Jan 31, 2019
@kingosticks kingosticks merged commit e5c03fb into mopidy:release-2.2 Jan 31, 2019
@kingosticks kingosticks deleted the fix/change-track-buffering-alt branch Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-audio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants