Disable buffering handling during track change. (Fixes #1722) #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodal
approved these changes
Jan 31, 2019
mopidy/audio/actor.py
Outdated
| @@ -740,6 +743,9 @@ def _set_state(self, state): | |||
| :type state: :class:`Gst.State` | |||
| :rtype: :class:`True` if successfull, else :class:`False` | |||
| """ | |||
| if (state < Gst.State.PAUSED): | |||
There was a problem hiding this comment.
You'd have thought I would have noticed when I already went and removed the semicolons at the end of lines.
|
Rebase on top of release-2.2? |
…1722). Skip handling buffering messages if pipeline not PLAYING or PAUSED.
kingosticks
force-pushed
the
fix/change-track-buffering-alt
branch
from
079cf7d
to
d6da4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Successor to #1734 which retains our GST
BUFFERINGmessage handling but prevents it from erroneously setting the pipeline statePLAYING/PAUSEDwhen we want to stay inREADY(during track changes).