Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable buffering handling during track change. (Fixes #1722) #1740

Merged

Conversation

@kingosticks
Copy link
Member

commented Jan 31, 2019

Successor to #1734 which retains our GST BUFFERING message handling but prevents it from erroneously setting the pipeline state PLAYING/PAUSED when we want to stay in READY (during track changes).

@jodal

jodal approved these changes Jan 31, 2019

@@ -740,6 +743,9 @@ def _set_state(self, state):
:type state: :class:`Gst.State`
:rtype: :class:`True` if successfull, else :class:`False`
"""
if (state < Gst.State.PAUSED):

This comment has been minimized.

Copy link
@jodal

jodal Jan 31, 2019

Member

The parenthesis are redundant.

This comment has been minimized.

Copy link
@kingosticks

kingosticks Jan 31, 2019

Author Member

You'd have thought I would have noticed when I already went and removed the semicolons at the end of lines.

@jodal

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

Rebase on top of release-2.2?

@kingosticks kingosticks force-pushed the kingosticks:fix/change-track-buffering-alt branch from 079cf7d to d6da4b5 Jan 31, 2019

@kingosticks kingosticks changed the base branch from develop to release-2.2 Jan 31, 2019

@kingosticks kingosticks merged commit e5c03fb into mopidy:release-2.2 Jan 31, 2019

@kingosticks kingosticks deleted the kingosticks:fix/change-track-buffering-alt branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.