emit stream_title_changed when title differs from track name

[kingosticks]

I've been using this change quite happily and seems worth it until we have proper stream type support.

[jodal]

LGTM.

Wondering if we should allow this in 2.2.3 or let it wait for 3.0...

Any comments, @adamcik?

[adamcik]

Either way, maybe just a point or minor release since it's been ages since there has been a release. So just put small things like this there and get whatever it adds up to out,

[jodal]

Any comments on the change itself?

[adamcik]

Nope, not really.

[eamanu]

what about

if current_track and current_track.name != title:

?

[kingosticks]

Any reason not to merge this as it is? I'm happy for it to sit in develop and wait for 3.0 if that's easier.

[kingosticks]

Actually, I need to update some tests.

[kingosticks]

Still needs a changelog entry but I need to know into which branch it's headed.

[jodal]

Target it at release-2.2. We can decide at release time if it is 2.2.4 or 2.3.0.

[kingosticks]

OK done.

[kingosticks]

Why is there no CI build triggered here?

[jodal]

I've turned on this CircleCI setting now:

Build forked pull requests

Run builds for pull requests from forks. CircleCI will automatically update the commit status shown on GitHub's pull request page.

Try force-pushing to trigger a build.

[codecov]

Codecov Report

Merging #1751 into release-2.2 will increase coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release-2.2    #1751      +/-   ##
===============================================
+ Coverage        80.99%   80.99%   +<.01%     
===============================================
  Files               83       83              
  Lines             6644     6646       +2     
===============================================
+ Hits              5381     5383       +2     
  Misses            1263     1263

Impacted Files	Coverage Δ
mopidy/core/actor.py	94.66% <100%> (+0.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91c573...dae56b4. Read the comment docs.

[kingosticks]

Now that is a coverage report!