Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close MPD connection following an exception in handler. #1765

Merged

Conversation

@kingosticks
Copy link
Member

kingosticks commented May 22, 2019

This goes towards fixing #1762. Needs some tests and changelog etc.

@kingosticks kingosticks added the A-mpd label May 22, 2019
@kingosticks kingosticks self-assigned this May 22, 2019
@kingosticks

This comment has been minimized.

Copy link
Member Author

kingosticks commented May 22, 2019

Oops, I meant to open this as a "draft" PR.

@kingosticks kingosticks force-pushed the kingosticks:fix/close-connection-on-failure branch from 4b143f1 to 5b1bfef May 22, 2019
@kingosticks kingosticks changed the title network: Close connection following an exception in handler close. Close MPD connection following an exception in handler. May 22, 2019
mopidy/internal/network.py Outdated Show resolved Hide resolved
@jodal jodal added this to the v2.2.3 milestone May 22, 2019
@jodal

This comment has been minimized.

Copy link
Member

jodal commented May 22, 2019

I guess this could go into 2.2.x and thus should be rebased upon release-2.2.

@kingosticks kingosticks force-pushed the kingosticks:fix/close-connection-on-failure branch from 5b1bfef to e7fab35 May 26, 2019
@jodal jodal added the C-bug label Jun 9, 2019
@jodal jodal modified the milestones: v2.2.3, v2.2.4 Jun 19, 2019
@kingosticks kingosticks force-pushed the kingosticks:fix/close-connection-on-failure branch from e7fab35 to af16f83 Jun 26, 2019
@kingosticks

This comment has been minimized.

Copy link
Member Author

kingosticks commented Jun 26, 2019

I couldn't really find a way to easily do the test I wanted with an exception raised in the handler running in a different actor, but I added something at least.

@jodal
jodal approved these changes Jun 26, 2019
Copy link
Member

jodal left a comment

LGTM. Rebase and retarget on release-2.2, and add a changelog entry, and you're free to merge.

@kingosticks kingosticks force-pushed the kingosticks:fix/close-connection-on-failure branch from af16f83 to 991e2c3 Jun 26, 2019
@kingosticks kingosticks changed the base branch from develop to release-2.2 Jun 26, 2019
@kingosticks kingosticks merged commit 49a08f1 into mopidy:release-2.2 Jun 26, 2019
@jodal jodal added this to the v2.3.0 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.