Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core API: Remove deprecated methods #1769

Merged
merged 5 commits into from Jun 9, 2019

Conversation

@jodal
Copy link
Member

jodal commented Jun 5, 2019

This removes all methods in the Core API that was deprecated in 1.0.

As the previous PR, this contributes to #1461 without resolving it fully.

@jodal jodal added the A-core label Jun 5, 2019
@jodal jodal added this to the v3.0 milestone Jun 5, 2019
@jodal jodal requested review from adamcik and kingosticks Jun 5, 2019
@jodal jodal self-assigned this Jun 5, 2019
@adamcik
adamcik approved these changes Jun 9, 2019
@@ -200,27 +200,3 @@ Core events

.. autoclass:: mopidy.core.CoreListener
:members:

Deprecated API features

This comment has been minimized.

Copy link
@adamcik

adamcik Jun 9, 2019

Member

Switch to Removed API features and just listing the things that are gone? I.e. how do we reduce confusion from people not finding stuff we've removed?

I know this is in the changelog, is that enough?

This comment has been minimized.

Copy link
@jodal

jodal Jun 9, 2019

Author Member

I believe it's better to remove it to avoid confusing visitors that searches for something, finds a result, and doesn't notice the header above what they're reading. I'd rather put in the effort to make the changelog or a migration guide really good. If searching the full docs site, I think it's best that the only hit for something removed is the changelog entry telling you that it was removed and what to use instead. If you need the full details of the removed APIs, docs for the previous release branches are also available.

docs/changelog.rst Outdated Show resolved Hide resolved
@jodal jodal merged commit 5f0ce6e into mopidy:develop Jun 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal jodal deleted the jodal:fix/remove-deprecated-methods branch Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.