Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove double-quotes around PLS File# entries #1771
+3
−3
Conversation
kingosticks
requested changes
Jun 7, 2019
mopidy/internal/playlists.py Outdated
endemics
force-pushed the
endemics:fix-quoted-uri
branch
from
4e88d42
to
5d4e8e4
Jun 7, 2019
jodal
approved these changes
Jun 9, 2019
|
LGTM! If you could rebase and target the PR on the |
jodal
added this to the v2.2.3 milestone
Jun 9, 2019
jodal
added
C-bug
A-stream
labels
Jun 9, 2019
endemics
changed the base branch from
develop
to
release-2.2
Jun 9, 2019
jodal
merged commit 6dbcc1a
into
mopidy:release-2.2
Jun 11, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
@endemics Thank you :-) |
endemics
deleted the
endemics:fix-quoted-uri
branch
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
endemics commentedJun 7, 2019
File#entries of PLS playlists may be found double quoted in the wild, since the "standard" is loosely defined. The resulting URI is then incorrect and makes mopidy fail to load the content, so let's make sure we strip them.Fixes #1770