Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double-quotes around PLS File# entries #1771

Merged
merged 1 commit into from Jun 11, 2019

Conversation

endemics
Copy link
Contributor

@endemics endemics commented Jun 7, 2019

File# entries of PLS playlists may be found double quoted in the wild, since the "standard" is loosely defined. The resulting URI is then incorrect and makes mopidy fail to load the content, so let's make sure we strip them.
Fixes #1770

mopidy/internal/playlists.py Outdated Show resolved Hide resolved
since the "standard" is loosely defined. The resulting URI is then
incorrect and makes mopidy fail to load the content, so let's make
sure we strip them.
Fixes mopidy#1770
jodal
jodal approved these changes Jun 9, 2019
Copy link
Member

@jodal jodal left a comment

LGTM!

If you could rebase and target the PR on the release-2.2 branch, it can go into the next 2.2.x bugfix release.

@jodal jodal added this to the v2.2.3 milestone Jun 9, 2019
@jodal jodal added C-bug A-stream labels Jun 9, 2019
@endemics endemics changed the base branch from develop to release-2.2 Jun 9, 2019
@jodal jodal merged commit 6dbcc1a into mopidy:release-2.2 Jun 11, 2019
1 check passed
@jodal
Copy link
Member

@jodal jodal commented Jun 11, 2019

@endemics Thank you :-)

@endemics endemics deleted the fix-quoted-uri branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stream C-bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants