Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PkgResourcesDeprecationWarning from mopidy/ext.py #1780

Conversation

@Simon-the-Sorcerer
Copy link

Simon-the-Sorcerer commented Jul 15, 2019

sry for creating a new PR. I'm only a little server admin and rebasing was too scary 馃槈.

I changed the base branch to release-2.2 and started again.

Lovely to find a PR with a fix just hours after I created the issue! :-)

A couple of comments:

According to this setuptools commit the new methods where added in setuptools 11.3 about five years ago. According to packages.debian.org, Debian oldstable (stretch) ships setuptools 33. In other words, we can safely remove the if hasattr(...) and instead assume the "new" API to be present.

Second, some tests in tests/test_ext.py are failing. It seems you simply need to update a mock definition ~3 places:

-mock_entry_point.load.return_value = DummyExtension
+mock_entry_point.resolve.return_value = DummyExtension

Lastly, please rebase the fix on top of the release-2.2 branch and make that branch the basis for the PR. That way we can ship the fix in the next 2.2 bugfix release. The develop branch will not be shipped until Mopidy 3.0 is ready.

@jodal jodal merged commit ecc6776 into mopidy:release-2.2 Jul 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal

This comment has been minimized.

Copy link
Member

jodal commented Jul 15, 2019

Thank you! :-)

@jodal jodal added this to the v2.2.4 milestone Jul 15, 2019
@jodal jodal added this to the v2.3.0 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.