Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logging #1783

Merged
merged 7 commits into from Aug 5, 2019
Merged

Simplify logging #1783

merged 7 commits into from Aug 5, 2019

Conversation

@jodal
Copy link
Member

jodal commented Aug 3, 2019

See #1452 for background and reasoning.

@jodal jodal added the A-config label Aug 3, 2019
@jodal jodal added this to the v3.0 milestone Aug 3, 2019
@jodal jodal requested review from adamcik and kingosticks Aug 3, 2019
@jodal jodal self-assigned this Aug 3, 2019
Fixes #1452
@kingosticks

This comment has been minimized.

Copy link
Member

kingosticks commented Aug 5, 2019

This looks really good, will be very useful I am sure.

@jodal jodal merged commit 0a7a5b2 into mopidy:develop Aug 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal jodal deleted the jodal:feature/1452-simplify-logging branch Sep 8, 2019
@adamcik

This comment has been minimized.

Copy link
Member

adamcik commented on docs/changelog.rst in c3dc70c Dec 19, 2019

This doesn't work as we send logs to stderr, you need mopidy -vvv 2>&1 | tee mopidy.log

This comment has been minimized.

Copy link
Member Author

jodal replied Dec 20, 2019

Or, we could create the StreamHandler with stream=sys.stdout?

I guess using stderr for logging and stdout for console output/interaction, like for mopidy local scan is the proper way to do it, so we should probably just update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.