Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote PendingDeprecationWarnings to DeprecationWarnings #1786

Closed
wants to merge 13 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 18, 2019

Fixes #1773.

@kingosticks kingosticks added the A-core label Sep 12, 2019
@kingosticks kingosticks added this to the v3.0 milestone Sep 12, 2019
@hugovk
Copy link
Contributor Author

@hugovk hugovk commented Nov 9, 2019

Merge conflicts resolved!

@jodal
Copy link
Member

@jodal jodal commented Nov 9, 2019

Thanks! I plan to merge this as soon as we've thrown out the last of the old deprecated fields, ref. #1083 and #1461.

setup.cfg Outdated Show resolved Hide resolved
mopidy/core/tracklist.py Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Nov 9, 2019

Codecov Report

Merging #1786 into develop will decrease coverage by 1.16%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1786      +/-   ##
===========================================
- Coverage    82.02%   80.85%   -1.17%     
===========================================
  Files           77       77              
  Lines         6319     6325       +6     
===========================================
- Hits          5183     5114      -69     
- Misses        1136     1211      +75
Impacted Files Coverage Δ
mopidy/core/tracklist.py 96.41% <100%> (+0.9%) ⬆️
mopidy/core/playback.py 76.97% <71.42%> (-14.78%) ⬇️
mopidy/mpd/protocol/playback.py 91.66% <75%> (-7.5%) ⬇️
mopidy/mpd/protocol/status.py 83.19% <0%> (-15.13%) ⬇️
mopidy/internal/deprecation.py 95% <0%> (-5%) ⬇️
mopidy/core/actor.py 90.47% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfe5ff...9e02d69. Read the comment docs.

mopidy/core/playback.py Show resolved Hide resolved
@hugovk hugovk force-pushed the promote-PendingDeprecationWarning branch from d917f0a to ddf3951 Compare Nov 9, 2019
@hugovk
Copy link
Contributor Author

@hugovk hugovk commented Nov 10, 2019

Got a bit stuck here, seems the new ones are not quite drop-in replacements! Could I hand this PR over?

@jodal
Copy link
Member

@jodal jodal commented Dec 14, 2019

Replaced by #1854. See the description there.

@jodal jodal closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants