Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle stream playlists containing relative URIs #1802

Merged

Conversation

@kingosticks
Copy link
Member

kingosticks commented Sep 17, 2019

This doesn't actually fix the example given in #1785 since it's a HLS stream and our stream backend will only play the first segment. We should fix HLS support separately.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #1802 into release-2.2 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-2.2    #1802      +/-   ##
===============================================
+ Coverage        80.99%   80.99%   +<.01%     
===============================================
  Files               83       83              
  Lines             6646     6647       +1     
===============================================
+ Hits              5383     5384       +1     
  Misses            1263     1263
Impacted Files Coverage Δ
mopidy/stream/actor.py 87.2% <100%> (ø) ⬆️
mopidy/compat.py 70% <100%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3904c7...d6d081e. Read the comment docs.

@kingosticks kingosticks force-pushed the kingosticks:fix/stream_playlist_relative_uri branch from 8303fda to 9dbe495 Sep 17, 2019
@jodal jodal added this to the v2.2.4 milestone Sep 25, 2019
@jodal
jodal approved these changes Sep 25, 2019
Copy link
Member

jodal left a comment

LGTM! There's a conflict in the changelog because of the PR I just merged.

@jodal jodal added the A-stream label Sep 25, 2019
@kingosticks kingosticks force-pushed the kingosticks:fix/stream_playlist_relative_uri branch from 9dbe495 to d6d081e Sep 25, 2019
@kingosticks kingosticks merged commit b66c2e8 into mopidy:release-2.2 Sep 25, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 80.99%)
Details
codecov/project 80.99% (+<.01%) compared to a3904c7
Details
test Workflow: test
Details
@kingosticks kingosticks deleted the kingosticks:fix/stream_playlist_relative_uri branch Sep 25, 2019
@jodal jodal added this to the v2.3.0 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.