Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2 cleanup and code modernization #1835

Merged
merged 12 commits into from Nov 8, 2019
Merged

Python 2 cleanup and code modernization #1835

merged 12 commits into from Nov 8, 2019

Conversation

@jodal
Copy link
Member

jodal commented Nov 8, 2019

No description provided.

@jodal jodal added this to the v3.0 milestone Nov 8, 2019
@jodal jodal self-assigned this Nov 8, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #1835 into develop will increase coverage by 0.25%.
The diff coverage is 83.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1835      +/-   ##
===========================================
+ Coverage    81.47%   81.72%   +0.25%     
===========================================
  Files           78       77       -1     
  Lines         6386     6195     -191     
===========================================
- Hits          5203     5063     -140     
+ Misses        1183     1132      -51
Impacted Files Coverage Δ
mopidy/mpd/protocol/command_list.py 100% <ø> (ø) ⬆️
mopidy/mpd/protocol/channels.py 100% <ø> (ø) ⬆️
mopidy/internal/formatting.py 76.47% <ø> (-1.31%) ⬇️
mopidy/mpd/protocol/mount.py 100% <ø> (ø) ⬆️
mopidy/mpd/protocol/reflection.py 100% <ø> (ø) ⬆️
mopidy/mpd/protocol/playback.py 99.01% <ø> (-0.01%) ⬇️
mopidy/internal/gi.py 77.77% <ø> (-1.17%) ⬇️
mopidy/mpd/protocol/connection.py 100% <ø> (ø) ⬆️
mopidy/httpclient.py 100% <ø> (ø) ⬆️
mopidy/mpd/protocol/audio_output.py 95.65% <ø> (-0.19%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed935a...3f9e537. Read the comment docs.

@jodal jodal merged commit 8e78980 into mopidy:develop Nov 8, 2019
3 checks passed
3 checks passed
codecov/patch 83.09% of diff hit (target 81.47%)
Details
codecov/project 81.72% (+0.25%) compared to fed935a
Details
test Workflow: test
Details
@jodal jodal deleted the jodal:py2-cleanup branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.