Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pytest assertions everywhere #1838

Merged
merged 2 commits into from Nov 9, 2019
Merged

Conversation

jodal
Copy link
Member

@jodal jodal commented Nov 9, 2019

pytest assertions are easier to read and give better error messages when the tests fails.

Though, we still have quite a bit of flipping of LHS and RHS to do before this feels proper.

@jodal jodal added this to the v3.0 milestone Nov 9, 2019
@jodal jodal self-assigned this Nov 9, 2019
@codecov
Copy link

@codecov codecov bot commented Nov 9, 2019

Codecov Report

Merging #1838 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1838   +/-   ##
========================================
  Coverage    81.72%   81.72%           
========================================
  Files           77       77           
  Lines         6215     6215           
========================================
  Hits          5079     5079           
  Misses        1136     1136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a053324...407bbb8. Read the comment docs.

@jodal jodal merged commit 66ca19f into mopidy:develop Nov 9, 2019
3 checks passed
@jodal jodal deleted the pytest-assertions branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant