Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Don't repeat Mopidy's deps for each extension #1846

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

jodal
Copy link
Member

@jodal jodal commented Nov 25, 2019

On one example setup, this reduces the output of mopidy deps from 499 to 137 lines. No data is lost, we just don't repeat the ~8 lines of dependencies of Mopidy itself for every extension that also depends on Mopidy.

@jodal jodal added this to the v3.0 milestone Nov 25, 2019
@jodal jodal self-assigned this Nov 25, 2019
@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #1846 into develop will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1846      +/-   ##
===========================================
- Coverage    82.04%   82.03%   -0.02%     
===========================================
  Files           77       77              
  Lines         6316     6318       +2     
===========================================
+ Hits          5182     5183       +1     
- Misses        1134     1135       +1
Impacted Files Coverage Δ
mopidy/internal/deps.py 91.42% <75%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5720197...cf867c0. Read the comment docs.

@@ -206,6 +206,10 @@ Extension support

This makes it easier to support arbitrary encoding in file names.

- The command :command:`mopidy deps` no longer repeats the dependencies of
Mopidy itself for every installed extension. This reduces the length of the
command's output drastically. (PR: TODO)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1846

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, is this good to merge?

At both my previous and current workplace, we have the convention of commenting+approving if we find minor issues, but don't feel the need to look at the PR again before it is merged, assuming the comments are somewhat addressed. A request changes is a quite strong "I'd like to have another look at this once you've addressed these issues".

On one example setup, this reduces the output of `mopidy deps` from 499
to 137 lines. No data is lost, we just don't repeat the ~8 lines of
dependencies of Mopidy itself for every extension that also depends on
Mopidy.
@jodal jodal force-pushed the feature/deps-without-mopidy-repeated branch from 879aa90 to cf867c0 Compare November 27, 2019 21:36
@jodal jodal merged commit 051b36a into mopidy:develop Nov 29, 2019
@jodal jodal deleted the feature/deps-without-mopidy-repeated branch November 29, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants