Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote APIs from "pending deprecation" to "deprecated" #1854

Merged
merged 5 commits into from Dec 14, 2019

Conversation

@jodal
Copy link
Member

jodal commented Dec 14, 2019

This PR builds upon #1786 by @hugovk, and takes the easy way out: We postpone the replacement of our usage of the deprecated APIs until after Mopidy 3.0 has been released. The important thing is to deprecate them, so that they can be removed in the next major, not to immediately stop using them ourselves.

@jodal jodal added the A-core label Dec 14, 2019
@jodal jodal added this to the v3.0 milestone Dec 14, 2019
@jodal jodal self-assigned this Dec 14, 2019
@jodal jodal added this to To do in Mopidy 3 on Python 3 via automation Dec 14, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #1854 into develop will decrease coverage by 0.06%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1854      +/-   ##
===========================================
- Coverage    82.23%   82.17%   -0.07%     
===========================================
  Files           77       77              
  Lines         6328     6334       +6     
===========================================
+ Hits          5204     5205       +1     
- Misses        1124     1129       +5
Impacted Files Coverage Δ
mopidy/core/playback.py 91.72% <100%> (ø) ⬆️
mopidy/core/tracklist.py 94% <50%> (-1.5%) ⬇️
mopidy/internal/deprecation.py 95% <0%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407b96f...fc50350. Read the comment docs.

@jodal jodal merged commit 259fa13 into mopidy:develop Dec 14, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 53.84% of diff hit (target 82.23%)
Details
codecov/project 82.17% (-0.07%) compared to 407b96f
Details
test Workflow: test
Details
Mopidy 3 on Python 3 automation moved this from To do to Done in master branch Dec 14, 2019
@jodal jodal deleted the jodal:1773/new-deprecations branch Dec 14, 2019
@jodal jodal mentioned this pull request Dec 14, 2019
4 of 4 tasks complete
@jodal jodal moved this from Done in master branch to Released in pre-release in Mopidy 3 on Python 3 Dec 14, 2019
@jodal jodal moved this from Released in pre-release to Released in final release in Mopidy 3 on Python 3 Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mopidy 3 on Python 3
  
Released in final release
2 participants
You can’t perform that action at this time.