Promote APIs from "pending deprecation" to "deprecated" #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to duplicate their logic. Once we're ready to remove the old methods, they'll be folded into the new ones.
Codecov Report
@@ Coverage Diff @@
## develop #1854 +/- ##
===========================================
- Coverage 82.23% 82.17% -0.07%
===========================================
Files 77 77
Lines 6328 6334 +6
===========================================
+ Hits 5204 5205 +1
- Misses 1124 1129 +5
Continue to review full report at Codecov.
|
4 tasks
jodal
moved this from Done in master branch
to Released in pre-release
in Mopidy 3 on Python 3
jodal
moved this from Released in pre-release
to Released in final release
in Mopidy 3 on Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR builds upon #1786 by @hugovk, and takes the easy way out: We postpone the replacement of our usage of the deprecated APIs until after Mopidy 3.0 has been released. The important thing is to deprecate them, so that they can be removed in the next major, not to immediately stop using them ourselves.