/ mopidy Public
Turn off strict parsing for pls playlist files #1923
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Some PLS files contain one 'Version' key for each file in the playlist. This ultimately has no impact on how mopidy parses files in the playlist, and therefore it should be as tolerant as possible of real-world playlist files.
Note that it isn't enough to simply catch
configparser.DuplicateOptionErrorand keep moving, as the config object ends up in a weird half-finished state that doesn't match its state when it has finished parsing without throwing.
Consideration should also be given switching away from
configparser.RawConfigParser, as the official python documentation recommends moving to
configparser.ConfigParser. I'd be happy to update this PR to switch this at the same time.