Turn off strict parsing for pls playlist files #1923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some PLS files contain one 'Version' key for each file in the playlist. This ultimately has no impact on how mopidy parses files in the playlist, and therefore it should be as tolerant as possible of real-world playlist files.
Codecov Report
@@ Coverage Diff @@
## develop #1923 +/- ##
========================================
Coverage 76.78% 76.78%
========================================
Files 55 55
Lines 4691 4691
========================================
Hits 3602 3602
Misses 1089 1089
Continue to review full report at Codecov.
|
djmattyg007
added a commit
to djmattyg007/mopidy-tunein
that referenced
this pull request
Jul 12, 2020
Some PLS files contain one 'Version' key for each file in the playlist. This ultimately has no impact on how mopidy parses files in the playlist, and therefore it should be as tolerant as possible of real-world playlist files. This matches a similar change request submitted to the mopidy core: mopidy/mopidy#1923
|
This was a regression introduced when we ported to Python 3 https://docs.python.org/3/library/configparser.html
|
|
I have to admit I had always meant to merge this as I did for Mopidy-TuneIn but I totally forgot. Thanks for the fix. Merged in 7f1bc23 |
|
Thank you! I did email the ABC but have yet to hear back from them, so this will help a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some PLS files contain one 'Version' key for each file in the playlist. This ultimately has no impact on how mopidy parses files in the playlist, and therefore it should be as tolerant as possible of real-world playlist files.
Note that it isn't enough to simply catch
configparser.DuplicateSectionErrororconfigparser.DuplicateOptionErrorand keep moving, as the config object ends up in a weird half-finished state that doesn't match its state when it has finished parsing without throwing.Consideration should also be given switching away from
configparser.RawConfigParser, as the official python documentation recommends moving toconfigparser.ConfigParser. I'd be happy to update this PR to switch this at the same time.