Fix memory leak when converting GST sample tags
#1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1929 +/- ##
===========================================
- Coverage 76.78% 76.64% -0.15%
===========================================
Files 55 55
Lines 4691 4701 +10
===========================================
+ Hits 3602 3603 +1
- Misses 1089 1098 +9
Continue to review full report at Codecov.
|
kingosticks
force-pushed
the
fix/scanner-tags-memory-leak
branch
from
57aa6e5
to
a527bbe
Compare
jodal
approved these changes
Aug 24, 2020
adamcik
approved these changes
Aug 24, 2020
…dy#1827) Embedded cover art, and other tags exposed to us as type Gst.Sample, were causing memory leaks when converted to plain Python types using GstBuffer.extract_dup(). extract_dup() expects the caller to free the memory it allocates but older versions of Python 3 PyGObject don't seem to do this. The workaround is to access buffer data using GstMemory methods instead. This issue was found to be present on Buster 10 systems (python-gi 3.30.4) but not on Ubuntu 20.04 (python-gi 3.36.0). Mopidy memory usage after scanning 2861 tracks: Without fix: 163.2MB With fix: 54.1MB
kingosticks
force-pushed
the
fix/scanner-tags-memory-leak
branch
from
a527bbe
to
55dec06
Compare
|
I just stumbled upon #1472 which was related to this. |
|
Hello, thanks for fixing this issue. When do you plan on merging back to the master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Embedded cover art, and other tags exposed to us as type
Gst.Sample, werecausing memory leaks when converted to plain Python types using
GstBuffer.extract_dup().extract_dup()expects the caller to free thememory it allocates but older versions of the python3-gi don't seem to do
this. The workaround is to access samples using
GstMemorymethods instead.This issue was present on Buster 10 systems (python-gi 3.30.4) but not on
Ubuntu 20.04 (python-gi 3.36.0).
Fixes #1827
Zulip Topic