Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to API change in gst-python >= 1.18 #1948

merged 1 commit into from Dec 19, 2020


Copy link

Without this with gst-python-1.18.2 while scanning files there are intermittent fails as follows:

ERROR    2020-12-18 18:39:25,302 [426578:Core-8] mopidy.core.library
  FileBackend backend caused an exception.
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/mopidy/core/", line 17, in _backend_error_handling
  File "/usr/lib/python3.9/site-packages/mopidy/core/", line 217, in lookup
    result = future.get()
  File "/usr/lib/python3.9/site-packages/pykka/", line 45, in get
  File "/usr/lib/python3.9/site-packages/pykka/_compat/", line 29, in reraise
    raise value
  File "/usr/lib/python3.9/site-packages/pykka/", line 193, in _actor_loop
    response = self._handle_receive(envelope.message)
  File "/usr/lib/python3.9/site-packages/pykka/", line 299, in _handle_receive
    return callee(*message.args, **message.kwargs)
  File "/usr/lib/python3.9/site-packages/mopidy/file/", line 98, in lookup
    result = self._scanner.scan(uri)
  File "/usr/lib/python3.9/site-packages/mopidy/audio/", line 70, in scan
    tags, mime, have_audio, duration = _process(pipeline, timeout)
  File "/usr/lib/python3.9/site-packages/mopidy/audio/", line 268, in _process
  File "/usr/lib/python3.9/site-packages/mopidy/audio/", line 83, in convert_taglist
    if data:
ValueError: operation forbidden on released memoryview object

It's the same problem as fixed in beetbox/audioread#110.

Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #1948 (1b738c3) into develop (9ae3520) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1948      +/-   ##
- Coverage    77.03%   76.99%   -0.04%     
  Files           55       55              
  Lines         4711     4713       +2     
  Hits          3629     3629              
- Misses        1082     1084       +2     
Impacted Files Coverage Δ
mopidy/audio/ 79.41% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae3520...1b738c3. Read the comment docs.

Copy link

Thanks, this is really helpful.

I don't recall this getting any mention in the the normal GStreamer changelog. I don't know where I am supposed to be looking for breaking API changes like this.

@kingosticks kingosticks added the A-audio Area: Audio layer label Dec 18, 2020
@jodal jodal added this to the Next bug fix release milestone Dec 19, 2020
@jodal jodal merged commit ed48e8f into mopidy:develop Dec 19, 2020
8 checks passed
Copy link

jodal commented Dec 19, 2020


@jodal jodal modified the milestones: Next bug fix release, v3.1.1 Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
A-audio Area: Audio layer
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants