Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/appsrc flags and live mode #1971

Merged

Conversation

kingosticks
Copy link
Member

@kingosticks kingosticks commented Jan 23, 2021

Reset our values for source live mode and playbin flags when using appsrc.
We don't want these options applied to appsrc (particularly live mode as that breaks track change).

test_not_live_mode() source.props was missing the is_live attribute
which made the test pointless. Moved source mock creation into
setup() so it's done correctly in one place.

Removed extra unused config dicts.
…idy#1969)

Reset our values for source live mode and playbin flags when using appsrc.
We don't want these options applied to appsrc.
@kingosticks kingosticks self-assigned this Jan 23, 2021
@kingosticks kingosticks added A-audio Area: Audio layer C-bug Category: This is a bug labels Jan 23, 2021
@kingosticks kingosticks added this to the Next bug fix release milestone Jan 23, 2021
Copy link
Member

@jodal jodal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to change the target branch to master before merging, or cherry-pick the commit to master afterwards.

@kingosticks kingosticks merged commit d92556e into mopidy:develop Jan 26, 2021
@kingosticks kingosticks deleted the fix/appsrc-flags-and-live-mode branch January 26, 2021 09:58
@jodal jodal modified the milestones: Next bug fix release, v3.2.0 Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-audio Area: Audio layer C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants