Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inline config comments broken in Mopidy 3 #1868 #2041

Merged
merged 3 commits into from Jan 21, 2022

Conversation

grdorin
Copy link
Contributor

@grdorin grdorin commented Jan 13, 2022

No description provided.

@kingosticks
Copy link
Member

If this could have a test that worked it'd be perfect. Because we had a test for this but for some reason it's not working

@kingosticks kingosticks added the A-config Area: Config management label Jan 13, 2022
@kingosticks kingosticks added this to the Next bug fix release milestone Jan 13, 2022
@kingosticks
Copy link
Member

Oh, and flake8 has an issue

@kingosticks kingosticks added the S-waiting-on-author Status: The marked issue/PR is awaiting some action (such as code changes) from the issue/PR author label Jan 19, 2022
adjusted implementation
@kingosticks
Copy link
Member

kingosticks commented Jan 21, 2022

Because we had a test for this but for some reason it's not working

OK, because that code being tested there doesn't appear to be being used in Mopidy anymore!? Seems was prep work for a feature we never did: #548

This still needs a test else it'll get silently broken again.

@kingosticks kingosticks self-assigned this Jan 21, 2022
@kingosticks kingosticks removed the S-waiting-on-author Status: The marked issue/PR is awaiting some action (such as code changes) from the issue/PR author label Jan 21, 2022
@kingosticks kingosticks merged commit 84eac87 into mopidy:develop Jan 21, 2022
@jodal jodal modified the milestones: Next bug fix release, v3.3.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config Area: Config management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants