End of track cleanup #346

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@jodal
Member
jodal commented Mar 19, 2013

This pull request reintroduces the changes originally done in pull request #231 to properly separate end-of-track and end-of-stream handling.

These changes breaks some existing functionality in Mopidy, and was thus reverted from the develop branch. The following issues must be resolved before this can be merged again:

  • #316 EOT changes makes "next" deadlock Mopidy
  • #320 EOT changes breaks random playback
@adamcik
Member
adamcik commented Jul 16, 2013

mopidy/mopidy-gmusic#2 has some relevant discussion on the issues reaming in this branch.

@hechtus
hechtus commented Jul 17, 2013

The fact that, BasePlaybackProvider::change_track() always returns True leads to the assumption, that change_track() always succeed. I would like to see that BasePlaybackProvider::play() evaluates the return value of change_track() and returns False when change_track() returns False.

@hechtus
hechtus commented Jul 17, 2013

Playing around with this patch I experienced, that ncmcpp (0.5.4) didn't got noticed about (gapless) track changes. It simply continues incrementing the time and does not change the current playing track in the current playlist. GMPC seems to got noticed. So, I don't know, if this is an issue of ncmcpp 0.5.4.

@hechtus
hechtus commented Jul 17, 2013

In general, I think gapless playback of remote media will still be an issue. The about-to-finish message comes too late. I was trying to play short mp3 audio files from http://. Sometimes it works, but mostly there is a noticeable gap between the tracks. So, prefetching the next song is crucial for gapless playback of remote media (e.g. Google Music).

@adamcik
Member
adamcik commented Oct 27, 2013

Should we perhaps just close this as a PR, as we obviously won't be using this code for anything but a reference at this point and move tracking to a proper bug?

@jodal
Member
jodal commented Oct 27, 2013

Agree. I'm closing this, as well as the issues that are only present in this branch.

@jodal jodal closed this Oct 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment