New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds basic proxy support for http source #689
Conversation
@@ -133,6 +134,32 @@ def _on_new_source(self, element, pad): | |||
|
|||
self._appsrc = source | |||
|
|||
def _on_source_setup(self, element, source): | |||
uri = element.get_property('uri') | |||
if not uri or not uri.startswith('http://'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be supported for other uri protocols too i.e mms, rt[sm]p ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should, I will expand my tests case.
Probably also needs a small change to the docs at http://docs.mopidy.com/en/develop/config/#confval-proxy/hostname |
Other option that I was considering, that I've also seen in other gstreamer code, is just to check if the element has a proxy property. And if it does set it. Code would be something like: |
#701 would solve the remaining proxy issue you mentioned, as we would not have recursive decode bins. |
We probably want to hook into the scanner in the same manner, also please pull develop. If you want we can merge this without the scanner fix and then do a second fix for that bit. |
This sounds good, I will do but I am away for a week.
|
For Issue #390
There is still a drawback with pls files :