Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic proxy support for http source #689

Merged
merged 5 commits into from May 8, 2014
Merged

Adds basic proxy support for http source #689

merged 5 commits into from May 8, 2014

Conversation

AlexandrePTJ
Copy link
Contributor

For Issue #390
There is still a drawback with pls files :

decodebin2 cannot decode plain text files

@@ -133,6 +134,32 @@ def _on_new_source(self, element, pad):

self._appsrc = source

def _on_source_setup(self, element, source):
uri = element.get_property('uri')
if not uri or not uri.startswith('http://'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be supported for other uri protocols too i.e mms, rt[sm]p ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, I will expand my tests case.

@kingosticks
Copy link
Member

Probably also needs a small change to the docs at http://docs.mopidy.com/en/develop/config/#confval-proxy/hostname

@adamcik
Copy link
Member

adamcik commented Feb 16, 2014

Other option that I was considering, that I've also seen in other gstreamer code, is just to check if the element has a proxy property. And if it does set it. Code would be something like: if hasattr(element.props, 'proxy'): .... or just trying to set it and catch the error. Though I never tested this out.

@adamcik
Copy link
Member

adamcik commented Feb 19, 2014

#701 would solve the remaining proxy issue you mentioned, as we would not have recursive decode bins.

@adamcik
Copy link
Member

adamcik commented Feb 20, 2014

We probably want to hook into the scanner in the same manner, also please pull develop. If you want we can merge this without the scanner fix and then do a second fix for that bit.

@AlexandrePTJ
Copy link
Contributor Author

This sounds good, I will do but I am away for a week.
Le 20 févr. 2014 23:36, "Thomas Adamcik" notifications@github.com a écrit
:

We probably want to hook into the scanner in the same manner, also please
pull develop. If you want we can merge this without the scanner fix and
then do a second fix for that bit.

Reply to this email directly or view it on GitHubhttps://github.com//pull/689#issuecomment-35678000
.

@jodal jodal added the Audio label May 6, 2014
@jodal jodal added this to the v0.19 - MPD playlist mgmt and other MPD improvements milestone May 6, 2014
@adamcik adamcik merged commit 6f06ec0 into mopidy:develop May 8, 2014
jodal added a commit that referenced this pull request May 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-audio Area: Audio layer C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants