New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: Support playlists in browse #749

Merged
merged 1 commit into from Jun 20, 2014

Conversation

3 participants
@trygveaa
Member

trygveaa commented Jun 20, 2014

Playlists are containers similar to directories. Treat them equally to support playlists when browsing.

I started on developing an extension to implement Spotifys browse feature. On the mpd side, this would be browsed with the standard browse feature. However, it provides Spotify playlists, not tracks. Therefore this change, so playlists can be represented in the browse view as well.

Note that the playlists are exposed as directories now. They could be exposed as standard playlists, but I would rather expose them as directories. Primarily because ncmpcpp allows you to view the content of directories without adding them, but only allows you to view the content of playlists through the playlist editor. The playlists in the playlist editor are only the playlists from /, so these will not show there.

mpd: Support playlists in browse
Playlists are containers similar to directories. Treat them equally to
support playlists when browsing.
@adamcik

This comment has been minimized.

adamcik commented on mopidy/mpd/dispatcher.py in 6c4ecae Jun 20, 2014

ref.type in (ref.DIRECTORY, ref.PLAYLIST) and ...

@adamcik

This comment has been minimized.

adamcik commented on mopidy/mpd/dispatcher.py in 6c4ecae Jun 20, 2014

Same here.

@adamcik

This comment has been minimized.

Member

adamcik commented Jun 20, 2014

Actually, I can just fix these myself and then I'll merge :-)

adamcik added a commit that referenced this pull request Jun 20, 2014

@adamcik adamcik merged commit e3e9ce2 into mopidy:develop Jun 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jodal

This comment has been minimized.

Member

jodal commented Jun 20, 2014

I believe this code it tested, and thus this change should be accompanied with a test case.

@trygveaa

This comment has been minimized.

Member

trygveaa commented Jun 20, 2014

I can't seem to find any tests for MpdContext.

@jodal

This comment has been minimized.

Member

jodal commented Jun 20, 2014

You can exercise it from the listall and listallinfo tests in tests/mpd/protocol/test_music_db.py.

@trygveaa

This comment has been minimized.

Member

trygveaa commented Jun 20, 2014

Pushed changes to test cases for this in this branch.

@jodal

This comment has been minimized.

Member

jodal commented Jun 20, 2014

Thanks! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment