New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: Create unique names for all items in browse #762

Merged
merged 1 commit into from Jun 24, 2014

Conversation

3 participants
@trygveaa
Member

trygveaa commented Jun 23, 2014

Replace the playlist uri/name mapping with a mapping for all the items
in browse. Check the mapping when browsing a path.

This has the added benefit of serving as a cache for browse, so we don't
need to traverse the path parts and lookup each of them for each call to
browse.

mpd: Create unique names for all items in browse
Replace the playlist uri/name mapping with a mapping for all the items
in browse. Check the mapping when browsing a path.

This has the added benefit of serving as a cache for browse, so we don't
need to traverse the path parts and lookup each of them for each call to
browse.
@kingosticks

This comment has been minimized.

Member

kingosticks commented Jun 23, 2014

If this aims to cache browse results for all extensions then I think this is undesirable. It should be up to individual extensions to cache their data as only they know how volatile it is.

@trygveaa

This comment has been minimized.

Member

trygveaa commented Jun 23, 2014

It doesn't cache browse results, only mappings between names/paths and URIs. E.g.:
/Spotify/Global top tracks <-> spotify:toplist:all

@kingosticks

This comment has been minimized.

Member

kingosticks commented Jun 24, 2014

Excellent, Sorry for my confusion, I had a feeling I was barking up the
wrong tree (github + phone = fail).
On 24 Jun 2014 00:24, "Trygve Aaberge" notifications@github.com wrote:

It doesn't cache browse results, only mappings between names/paths and
URIs. E.g.:
/Spotify/Global top tracks <-> spotify:toplist:all


Reply to this email directly or view it on GitHub
#762 (comment).

@jodal jodal self-assigned this Jun 24, 2014

jodal added a commit that referenced this pull request Jun 24, 2014

Merge pull request #762 from trygveaa/fix/mpd-browse-duplicate
mpd: Create unique names for all items in browse

@jodal jodal merged commit 420b530 into mopidy:develop Jun 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@trygveaa trygveaa deleted the trygveaa:fix/mpd-browse-duplicate branch Jun 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment