New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH662 Fix for mopidy.audio on streams #796

Merged
merged 2 commits into from Jul 26, 2014

Conversation

2 participants
@ifosch
Contributor

ifosch commented Jul 26, 2014

So, the track length should not never be less than 0.

Fix mopidy/audio/scan.py to avoid negative values in track lengths
The fix is the most elegant I found, but it might pass undetected.

@ifosch ifosch referenced this pull request Jul 26, 2014

Closed

MPD reports stream length as -1 #662

2 of 2 tasks complete
@jodal

This comment has been minimized.

Member

jodal commented Jul 26, 2014

I think returning 0 like you do here makes sense for now, since we're actually returning 0 and not None for e.g. unknown time position too. Changing these from being 0 to None when unknown should be done at the same time as part of a future core API change.

jodal added a commit that referenced this pull request Jul 26, 2014

Merge pull request #796 from ifosch/gh662
Fix negative track lengths on radio streams. Fixes #662.

@jodal jodal merged commit c3011c1 into mopidy:develop Jul 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jodal jodal added this to the v0.19.3 milestone Jul 26, 2014

@jodal jodal self-assigned this Jul 26, 2014

@jodal jodal added the Audio label Jul 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment