Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support utf-8 chars in m3u playlists #929

Merged
merged 3 commits into from Jan 4, 2015

Conversation

kingosticks
Copy link
Member

Non-ascii utf-8 chars in a .m3u playlist will cause an error similar to the following:

2015-01-02 17:22:31,232 - ERROR GStreamer encountered a general supporting library error. Debug message: /usr/local/lib/python2.7/dist-packages/mopidy/audio/playlists.py(212): _event (): /GstPlayBin2:playbin20/GstURIDecodeBin:uridecodebin4/GstDecodeBin2:decodebin21/mopidy+audio+playlists+M3uDecoder:mopidy+audio+playlists+m3udecoder1:
<type 'exceptions.UnicodeDecodeError'>: 'ascii' codec can't decode byte 0xc3 in position 31: ordinal not in range(128)

This error only occurs if you don't enable the mopidy-mpris extension (#853 for more details).
I added utf-8 characters to all the test playlists even though the other parsers use libraries rather than directly manipulating the bytestrings and are therefore unaffected.

I'm not sure if parse_urilist needs this fix too, presumably it could contain non-ascii character comments.

@jodal jodal added this to the v0.19.6 - Bug fixes milestone Jan 4, 2015
@jodal jodal added the A-audio Area: Audio layer label Jan 4, 2015
jodal added a commit that referenced this pull request Jan 4, 2015
@jodal jodal merged commit 378daeb into mopidy:develop Jan 4, 2015
@jodal
Copy link
Member

jodal commented Jan 4, 2015

Thanks :-)

@jodal jodal self-assigned this Jan 4, 2015
@jodal
Copy link
Member

jodal commented Jan 4, 2015

Cherry-picked back to the release/v0.19.x branch for inclusion in Mopidy 0.19.6.

@jodal jodal modified the milestones: v0.19.6 - Bug fixes, v0.20 - Audio cleanup 1 Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-audio Area: Audio layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants