New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate stream metadata #938

Merged
merged 7 commits into from Feb 10, 2015

Conversation

3 participants
@AlexandrePTJ
Contributor

AlexandrePTJ commented Jan 17, 2015

This is a proposal for #270

@AlexandrePTJ

This comment has been minimized.

Contributor

AlexandrePTJ commented Jan 21, 2015

Last commit introduce a bug : if going from a stream to a local media, currentsong might return the stream metadata instead.

@AlexandrePTJ

This comment has been minimized.

Contributor

AlexandrePTJ commented Feb 3, 2015

That's ok, no problem with local media

@jodal

This comment has been minimized.

Member

jodal commented Feb 9, 2015

@adamcik There are new commits to review in this PR :-)

@jodal jodal changed the title from Feature/frontend audioevents to Expose stream metadata Feb 9, 2015

@jodal jodal changed the title from Expose stream metadata to Propagate stream metadata Feb 9, 2015

adamcik added a commit that referenced this pull request Feb 10, 2015

@adamcik adamcik merged commit fcab27b into mopidy:develop Feb 10, 2015

2 checks passed

Scrutinizer 4 updated code elements
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@adamcik

This comment has been minimized.

Member

adamcik commented Feb 10, 2015

Now I just have to merge/rebase this cleanly against my gapless branch which has some similar changes :p

Thanks for taking the time implement this long missing piece.

@AlexandrePTJ

This comment has been minimized.

Contributor

AlexandrePTJ commented Feb 10, 2015

Thanks, you're welcome :)

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Feb 10, 2015

@jodal jodal removed the 3 - Done label Feb 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment