New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-set volume explicitly to the current level whenever changing tracks. #958

Merged
merged 2 commits into from Feb 12, 2015

Conversation

4 participants
@jcass77
Member

jcass77 commented Feb 3, 2015

Workaround for issue #886.

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 3, 2015

Note that https://github.com/adamcik/mopidy/tree/feature/implement-gapless might break this and/or make it unneeded.

Also for a workaround like this a comment referring to the issue number is nice so we can keep track on why it was added.

@jodal

This comment has been minimized.

Member

jodal commented Feb 9, 2015

+1 to this simple workaround

@adamcik Do you have any ideas on how to fix this properly and permanently?

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Feb 9, 2015

@jodal

This comment has been minimized.

Member

jodal commented Feb 9, 2015

@jcass77 I didn't notice that you had pushed a fix to @adamcik's comment until I went checking the PR now. Please comment when you update the PR, as GitHub doesn't send mail notifications on new commits in a PR. :-)

@jodal jodal added the 2 - Working label Feb 9, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 10, 2015

Hmm, we should probably get this in so we at least have a workaround for the next release. Then for the following release I hope we can remove this again depending on how the gapless changes effect this issue.

@jcass77 could we ping you when we have that code ready enough for you to give it a quick spin?

@jcass77

This comment has been minimized.

Member

jcass77 commented Feb 11, 2015

@adamcik yes please.

adamcik added a commit that referenced this pull request Feb 12, 2015

Merge pull request #958 from jcass77/master
Re-set volume explicitly to the current level whenever changing tracks.

@adamcik adamcik merged commit c771035 into mopidy:master Feb 12, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@adamcik

This comment has been minimized.

Member

adamcik commented Feb 12, 2015

Note that this was opened against master, we normally only merge things against develop before cutting a release to master. Whoops...

@jodal

This comment has been minimized.

Member

jodal commented Feb 12, 2015

I manually merged this into develop.

@jodal jodal added 3 - Done and removed 2 - Working labels Feb 12, 2015

@jcass77 jcass77 deleted the jcass77:master branch Feb 22, 2015

@jcass77

This comment has been minimized.

Member

jcass77 commented Feb 22, 2015

Works for me - thank you.

@ZenithDK

This comment has been minimized.

Contributor

ZenithDK commented Mar 10, 2015

Should this get a changelog entry?

@jodal

This comment has been minimized.

Member

jodal commented Mar 10, 2015

If it doesn't already, yes!

@jodal

This comment has been minimized.

Member

jodal commented Mar 10, 2015

- Add workaround for volume not persisting across tracks on OS X.
  (Issue: :issue:`886`, PR: :issue:`958`)                        
@ZenithDK

This comment has been minimized.

Contributor

ZenithDK commented Mar 18, 2015

Uh, I checked after assigning the label, can see that someone already fixed it in a sneaky way without saying so ;-)

@ZenithDK ZenithDK removed the 2 - Working label Mar 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment