New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share MPD playlist uri mapping between sessions #968

Merged
merged 5 commits into from Feb 9, 2015

Conversation

2 participants
@kingosticks
Member

kingosticks commented Feb 9, 2015

This my attempt at fixing #934 by maintaining a single name<->uri mapping which lives in the MPD frontend and is shared between all MPD sessions. I hope this is the right idea.

Arguably MPDUriMapper might deserve a better name and be moved out of dispatcher.py. It may deserve it's own tests but it does get some coverage in test_stored_playlists.

@jodal

This comment has been minimized.

Member

jodal commented Feb 9, 2015

+1

Nothing to comment on, except, as you point out yourself, MpdUriMapper doesn't really belong in dispatcher.py any longer. Move to mopidy/mpd/uri_mapper.py?

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Feb 9, 2015

@jodal jodal self-assigned this Feb 9, 2015

@jodal jodal added the 2 - Working label Feb 9, 2015

@kingosticks

This comment has been minimized.

Member

kingosticks commented Feb 9, 2015

Excellent, hopefully this is all now good to merge..

@jodal jodal added 3 - Done and removed 2 - Working labels Feb 9, 2015

jodal added a commit that referenced this pull request Feb 9, 2015

Merge pull request #968 from kingosticks/fix/session-playlist-uri-map…
…ping

Share MPD playlist uri mapping between sessions

@jodal jodal merged commit 52457df into mopidy:develop Feb 9, 2015

2 checks passed

Scrutinizer 5 updated code elements
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jodal jodal removed the 3 - Done label Feb 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment