Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/removeable outputs #97

Merged
merged 17 commits into from May 19, 2011

Conversation

2 participants
@adamcik
Copy link
Member

adamcik commented May 17, 2011

Fixes #80 with respect to shoutcast and provides the backend support required for #81. Not sure how problems with other outputs should be handled, so not adding anything more for now.

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/gstreamer.py in 743235b May 17, 2011

What about raising LookupError?

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/outputs/__init__.py in 3f35e9b May 17, 2011

s/sub classes/subclasses/

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/gstreamer.py in 2174723 May 17, 2011

s/handeled/handled/

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/gstreamer.py in eb5facd May 17, 2011

s/message comming/messages coming/

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/gstreamer.py in eb5facd May 17, 2011

Should use :meth:mopidy.outputs.base.BaseOutput.on_connect``to get links in the docs. Same foron_remove.

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/gstreamer.py in eb5facd May 17, 2011

:class:True is used elsewhere in the docs.

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/gstreamer.py in eb5facd May 17, 2011

Get rid of the parenthesis.

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/gstreamer.py in eb5facd May 17, 2011

s/from./from/

@jodal

This comment has been minimized.

Copy link

jodal commented on mopidy/gstreamer.py in eb5facd May 17, 2011

Use :class: for gst.Message and True as well.

@jodal

This comment has been minimized.

Copy link
Member

jodal commented May 17, 2011

Looks good! I've added some comments, but only regarding docs/typos.

@adamcik

This comment has been minimized.

Copy link
Member Author

adamcik commented May 18, 2011

Feel free to push the magic button :)

@jodal jodal merged commit 1503caa into mopidy:develop May 19, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.