Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search API has been broken by Spotify #183

Closed
adamcik opened this issue Feb 11, 2016 · 7 comments

Comments

3 participants
@adamcik
Copy link
Member

commented Feb 11, 2016

mopidy/mopidy-spotify#89

Best bet is likely to retrofit the new web API within the existing API wrapper to keep things working with minimal external API changes.

@adamcik adamcik added the bug label Feb 11, 2016

@trygveaa

This comment has been minimized.

Copy link
Member

commented Feb 11, 2016

How is the state of login credentials in libspotify vs. the new API?

@adamcik

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2016

https://developer.spotify.com/web-api/migration-guide/ has the migration guide for the old metadata API, but it's not clear what parts libspotify uses. I know at least search is effected.

As for the auth story, https://developer.spotify.com/web-api/endpoint-reference/ has the overview. For basic lookups you don't need OAuth, but for playlists and browse you typically do.

@adamcik

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2016

Also since this looks like just search for now a workaround should be relatively simple to hack up.

@adamcik

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2016

Longer term we probably need to go the route that mopidy-spotify-web has already started down...

@trygveaa

This comment has been minimized.

Copy link
Member

commented Feb 11, 2016

Okay, so the migration guide mentions these new endpoints:

/v1/albums/{id}
/v1/artists/{id}
/v1/artists/{id}/albums
/v1/search?q=foo&type=album
/v1/search?q=foo&type=artist
/v1/search?q=foo&type=track
/v1/tracks/{id}

From the endpoint reference, none of these require authentication. So we can implement support for these in pyspotify without requiring any additional authentication, so that's at least good.

@trygveaa

This comment has been minimized.

Copy link
Member

commented Feb 14, 2016

For information, this has been fixed for now in Mopidy-Spotify with mopidy/mopidy-spotify#95. It's undecided if we want a fix for this in pyspotify, or to keep pyspotify only as a plain wrapper around libspotify.

@jodal jodal changed the title Metadata APIs have been deprecated by spotify Search API have been broken by Spotify Feb 18, 2016

@jodal jodal changed the title Search API have been broken by Spotify Search API has been broken by Spotify Feb 18, 2016

@jodal jodal added this to the v2.1.0 milestone Jul 8, 2019

@jodal jodal self-assigned this Jul 8, 2019

@jodal

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Just to get it on the record:

The scope of the pyspotify project is to be a libspotify wrapper. pyspotify already covers the full libspotify API, and pyspotify is thus a mostly complete project.

Any support for the Spotify Web API is out of scope for the pyspotify project.

@jodal jodal closed this in a79c029 Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.