New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetch UserAgent crash #239

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@hearsilent

hearsilent commented May 3, 2017

Catch AndroidRuntimeException that could be raised by the WebSettings.getDefaultUserAgent() in some custom ROMs (e.g. OPPO, HTC, Sony, ASUS, Xiaomi ...).

Crashlytics Issue Details Screenshot:
default

Crash StackTrace:

Fatal Exception: android.util.AndroidRuntimeException: java.lang.RuntimeException: Invalid reflection
       at android.webkit.WebViewFactory.getProvider(WebViewFactory.java:146)
       at android.webkit.WebSettings.getDefaultUserAgent(WebSettings.java:1244)
       at com.mopub.network.Networking.getUserAgent(Networking.java:133)
       at com.mopub.network.Networking.getRequestQueue(Networking.java:63)
       at com.mopub.nativeads.MoPubNative.requestNativeAd(MoPubNative.java:192)
       at com.mopub.nativeads.MoPubNative.loadNativeAd(MoPubNative.java:177)
       at com.mopub.nativeads.MoPubNative.makeRequest(MoPubNative.java:152)
       at com.mopub.nativeads.MoPubNative.makeRequest(MoPubNative.java:137)
       ...

@hearsilent hearsilent changed the title Fix fetch user agent crash Fix fetch UserAgent crash May 3, 2017

@diousk

This comment has been minimized.

diousk commented Jul 3, 2017

Hi MoPub SDK team,
I've seen this issue in our app again in recent days (about "500 crashes" per day last week),
and I noticed that the "Android System WebView" app on the Google Play also got an update last weeek
(https://play.google.com/store/apps/details?id=com.google.android.webview)

Is this issue relevant to the webview update? and when is this PR ready to be merged?

Thanks.

@raymondctc raymondctc referenced this pull request Aug 22, 2017

Closed

Fix fetch UserAgent crash #2

@hearsilent

This comment has been minimized.

hearsilent commented Aug 24, 2017

MoPub Team has fixed this issue (328dcd8)
But doesn't merge my PR :'(

@hearsilent hearsilent closed this Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment